From: William C. <wc...@nc...> - 2003-01-30 14:52:30
|
Philippe Elie wrote: > William Cohen wrote: > > >> John Levon wrote: >> >>>> - Fix opcontrol to handle 64bit kernel offsets. Im not sure >>>> why opcontrol was using perl where op_start just parsed it with >>>> grep/cut. >>> >>> >>> >>> >>> Looking at the objdump header's values should be more portable. Will >>> made this change : >>> >>> >>>> - tmp1=`perl -le '($a, $b, $c, $d) = @ARGV; printf "%x\n", >>>> (hex($d))' $range_info` >>>> - tmp2=`perl -le '($a, $b, $c, $d) = @ARGV; printf "%x\n", >>>> (hex($c) + hex($d))' $range_info` >>> >>> >>> >>> >>> I'd prefer to just fix this code. Will ? >> >> >> >> The old implementation assumed that all kernels mark the end of the >> text with _stext. There were some kernels that I looked at the didn't >> mark the end in that manner. I don't remember which ones specifically >> (I looked at sparc, ia64, or ppc32). Rather than trying to enumerate >> all the possible special symbol name variation on the different >> targets and try to predict future name variations, I just decided to >> extract the start of text and the length using objdump and then >> compute the end. >> >> How did this code fail on the ppc64? > > > we can't do arithmetic in perl nor using print %[integer format] > as we manipulate unsigned long long and perl can't handle them. > String must be manipulate as it and passed to daemon. This means > interface to daemon must be changed, passing start and size rather > start and end. Using nm is not going to work with stripped kernel. Red Hat distributes some kernel as stripped, so going back to nm is not going to work either. Could we use the --adjust-vma option in objdump to compute the end address? first objdump used to get start address and length, make a second call to objdump with '--adjust-vma=length' and extract the end address from that. Having the deamon accept the start and length as an option sounds like less of a hack. -Will > > Anton is objdump -h parsing will give the same results as nm ? > > regards, > Phil > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list > |