Re: [PATCH] 64/32 correctness for daemon/

[Philippe E. <ph...@wa...>]

Randolph Chung wrote:

> Index: opd_cookie.h


> +#if defined(__hppa__)
> +static inline int lookup_dcookie(cookie_t cookie, char * buf, size_t size)
> +{
> +	/* ABI specifies that 64-bit values cannot be passed on odd-numbered
> +	 * registers
> +	 */
> +	extern size_t kernel_pointer_size;
> +
> +	if (kernel_pointer_size == 8) {
> +		return syscall(opd_nr_lookup_dcookie, 
> +			(unsigned long)(cookie >> 32), 
> +			(unsigned long)(cookie & 0xffffffff), buf, size);
> +	} else {
> +		return syscall(opd_nr_lookup_dcookie, (unsigned long)cookie, 
> +			buf, size);

John, we discuss Randolph and me about this else part,
it can't work and it seems there is no easy work-around.
I'm committing something like:

	} else {
			printf("parsic 32 bits kernel unsupported\n");
			exit(EXIT_FAILURE);

Randolph, is the solution to add a wrapper in sys_parisc.c, in the same
way as parisc_pread64() ?

regards,
Phil