From: William C. <wc...@nc...> - 2002-09-04 18:45:08
|
John Levon wrote: > On Tue, Sep 03, 2002 at 10:30:04AM -0400, Will Cohen wrote: [snip...] >>I would like to make eip an "unsigned long eip". I would like to remove >>as many "#ifdef"s as possible. We should be aware the structure field >>order causes eip to straddle 64bit words. Could we change the order of >>fields to make eip 64-bit aligned? On processors 64-bit processors this >>is going to make accessing eip expensive. > > > Yes, sure. Here is what I have to eliminate the #ifdef's between ia64 and ia32 structs. It builds on ia32 (no other changes from cvs) and ia64 (with the patches in earlier email). I changed the order of the fields in op_sample to make sure that eip is aligned. I noticed that struct op_sample is 20 bytes in size for 64-bit platforms. Comments about the patch? 2002-09-04 Will Cohen <wc...@re...> * libop/op_interface.h (op_sample, op_note): Make capatible with 64-bit targets. * dae/opd_proc.c (opd_put_sample): Adjust verbprintf arguments. (opd_handle_fork): Ditto. * dae/oprofiled.c (opd_do_samples): Ditto. -Will |