From: William C. <wc...@us...> - 2016-09-23 18:14:03
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "oprofile". The branch, master has been updated via b3c20ae8b52c10aa631ca0b931388df98ca3183d (commit) from 249fe0a4bb69e5bd2e9ee0a0667d925a86d4337c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b3c20ae8b52c10aa631ca0b931388df98ca3183d Author: Michael Petlan <mp...@re...> Date: Fri Sep 23 13:35:54 2016 +0200 Intel Goldmont default event Hi all, when testing oprofile on an Intel Goldmont machine, I have found out that the default event cpu_clk_unhalted returns always zero. Thus, I checked the configuration and Intel SDM, and I think there must be a mistake. According to the Intel SDM, table 19-24, the event is 0x3c as usual. It has two unit masks (0x00 (core_p) and 0x01 (ref)). With this, the event starts giving reasonable results. The current configuration which is coded in oprofile is not even in the SDM tale 19-24, so it is expectable that the following will give zero value: perf stat -e cpu/event=0x00,umask=0x02/ ls Please consider applying the attached patch. CC'ing Andi to verify the fix. Thank you, Michael commit df73e385442236fd6e763cc192185c606e59feda Author: Michael Petlan <mp...@re...> Date: Fri Sep 23 13:16:00 2016 +0200 Fixed default event on Intel Goldmont According to the Intel SDM, table 19-24, the event cpu_clk_unhalted has the event number 0x3c and has two unit masks (0x00, 0x01). This also corresponds to other Intels where the event is also 0x3c. Tested on a Goldmont Harrisonville (model 95). Before the patch: $ ocount ls Events were actively counted for 1761229 nanoseconds. Event counts (actual) for /usr/bin/ls: Event Count % time counted cpu_clk_unhalted 0 100.00 After the patch: Event counts (actual) for /usr/bin/ls: Event Count % time counted cpu_clk_unhalted 2,948,142 100.00 Signed-off-by: Michael Petlan <mp...@re...> ----------------------------------------------------------------------- Summary of changes: events/i386/goldmont/events | 2 +- events/i386/goldmont/unit_masks | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- oprofile |