[oprof-cvs] [SF SCMS]oprofile branch master updated. 91f485700fcfd67914b47696983795a6d66db8f5

[William C. <wc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "oprofile".

The branch, master has been updated
       via  91f485700fcfd67914b47696983795a6d66db8f5 (commit)
      from  9751bb834a18a1be08733fbcbb1b5947fd946ed5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 91f485700fcfd67914b47696983795a6d66db8f5
Author: William Cohen <wc...@re...>
Date:   Fri Jul 25 15:00:46 2014 -0400

    Fixes for coverity reported issues in opagent.c
    
    The patch fixes the following errors:        :
    
    Error: COMPILER_WARNING:
    oprofile-1.0.0git/libopagent/opagent.c: scope_hint: In function 'op_open_agent'
    oprofile-1.0.0git/libopagent/opagent.c:205:2: warning: implicit declaration of function 'flock' [-Wimplicit-function-declaration]
      rc = flock(fd, LOCK_EX | LOCK_NB);
      ^
    
    Error: RESOURCE_LEAK (CWE-772):
    oprofile-1.0.0git/libopagent/opagent.c:195: alloc_fn: Storage is returned from allocation function "fdopen(int, char const *)".
    oprofile-1.0.0git/libopagent/opagent.c:195: var_assign: Assigning: "dumpfile" = storage returned from "fdopen(fd, "w")".
    oprofile-1.0.0git/libopagent/opagent.c:213: leaked_storage: Variable "dumpfile" going out of scope leaks the storage it points to.
    
    Error: UNINIT (CWE-457):
    oprofile-1.0.0git/libopagent/opagent.c:266: var_decl: Declaring variable "dumpfd" without initializer.
    oprofile-1.0.0git/libopagent/opagent.c:285: uninit_use_in_call: Using uninitialized value "dumpfd" when calling "flock()".
    
    Error: COMPILER_WARNING:
    oprofile-1.0.0git/libopagent/opagent.c: scope_hint: In function 'op_close_agent'
    oprofile-1.0.0git/libopagent/opagent.c:285:5: warning: 'dumpfd' may be used uninitialized in this function [-Wmaybe-uninitialized]
      rc = flock(dumpfd, LOCK_EX | LOCK_NB);
         ^

-----------------------------------------------------------------------

Summary of changes:
 libopagent/opagent.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
oprofile