Re: [PATCH] Provide basic AArch64 support

[Will D. <wil...@ar...>]

On Thu, Jan 30, 2014 at 09:15:43PM +0000, Maynard Johnson wrote:
> On 01/30/2014 02:42 PM, William Cohen wrote:
> > The AArch64 support is provided as an ARM variant to allow use in both
> > 32-bit and 64-bit ARM environments.  The support in this patch is just
> > the basic events described in the AArch64 documentation.  AArch64
> > processor implementation may provide additional implementation
> > specific events.  One could add code to recognize those processor
> > specific implementations and include the armv8-common base events into
> > the event sets for the processor implementation specific events.
> > 
> The patch looks fine to me, AFAICT.  How about you, *Will D*?

The patch looks mostly alright to me, but there are two things worth noting:

  (1) Not all of the events listed here are mandated (i.e. they may not
      count on a given CPU implementation)

  (2) The uses of armv8_common and CPU_ARM_V8_COMMON would be more precise
      if we mentioned pmuv3 in there somewhere. At some point we'll probably
      get PMUv4, and then the common events might not be common anymore.

Will