From: Maynard J. <may...@us...> - 2013-05-28 13:35:02
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "oprofile". The branch, master has been updated via 6ee9806fbb2e12cf32d26a85f55d834c5accf77d (commit) from 3b11e2b116c902b1aa6477d2038e5d746f0041a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ee9806fbb2e12cf32d26a85f55d834c5accf77d Author: Maynard Johnson <may...@us...> Date: Tue May 28 08:19:25 2013 -0500 Fix Coverity errors found on May 20, 2013 git snapshot Coverity identified the following errors on scans run from May 7 through May 20, 2013: Type,Category,File,Function Wrapper object use after free,Memory - illegal accesses,/agents/jvmpi/jvmpi_oprofile.cpp,compiled_method_load(JVMPI_Event *) Unchecked return value,Error handling issues,/daemon/opd_mangling.c,opd_open_sample_file Dereference after null check,Null pointer dereferences,/daemon/opd_sfile.c,sfile_hash Uninitialized scalar field,Uninitialized members,/gui/oprof_start_config.cpp,config_setting::config_setting() Division or modulo by zero,Integer handling issues,/libdb/db_stat.c,odb_hash_stat Resource leak,Resource leaks,/libop/op_cpu_type.c,_auxv_fetch Resource leak,Resource leaks,/libop/op_cpu_type.c,fetch_at_hw_platform Negative array index read,Memory - illegal accesses,/libop/op_events.c,_is_um_valid_bitmask Write to pointer after free,Memory - corruptions,/libop/op_events.c,read_events Read from pointer after free,Memory - illegal accesses,/libop/op_events.c,_is_um_valid_bitmask Dereference after null check,Null pointer dereferences,/libop/op_mangle.c,op_mangle_filename Dereference after null check,Null pointer dereferences,/libop/op_mangle.c,op_mangle_filename Time of check time of use,Security best practices violations,/libopagent/opagent.c,op_open_agent Improper use of negative value,Integer handling issues,/libperf_events/operf_counter.cpp,operf_record::setup() Double free,Memory - corruptions,/libperf_events/operf_counter.cpp,operf_record::setup() Uninitialized pointer read,Memory - illegal accesses,/libperf_events/operf_counter.cpp,<unnamed>::_get_perf_event_from_file(mmap_info &) Unchecked return value,Error handling issues,/libperf_events/operf_mangling.cpp,"operf_open_sample_file(odb_t *, operf_sfile *, operf_sfile *, int, int)" Using invalid iterator,API usage errors,/libperf_events/operf_process_info.cpp,operf_process_info::try_disassociate_from_parent(char *) Non-array delete for scalars,Memory - illegal accesses,/libregex/op_regex.cpp,"<unnamed>::op_regerror(int, const re_pattern_buffer &)" Resource leak,Resource leaks,/libutil++/op_bfd.cpp,"op_bfd::op_bfd(const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, const string_filter &, const extra_images &, bool &)" Explicit null dereferenced,Null pointer dereferences,/opjitconv/create_bfd.c,fill_symtab Resource leak,Resource leaks,/opjitconv/opjitconv.c,_cleanup_jitdumps Use of untrusted string value,Insecure data handling,/opjitconv/opjitconv.c,main Resource leak,Resource leaks,/pe_profiling/operf.cpp,_get_cpu_for_perf_events_cap() Dereference null return value,Null pointer dereferences,/pe_profiling/operf.cpp,_process_session_dir() Incorrect deallocator used,API usage errors,/pe_profiling/operf.cpp,_process_events_list() =============================== This patch fixes those errors. Signed-off-by: Maynard Johnson <may...@us...> ----------------------------------------------------------------------- Summary of changes: agents/jvmpi/jvmpi_oprofile.cpp | 4 +- daemon/opd_mangling.c | 7 +++++- gui/oprof_start_config.cpp | 1 + libdb/db_stat.c | 3 +- libop/op_cpu_type.c | 12 ++++++++++ libop/op_events.c | 10 ++++---- libop/op_mangle.c | 2 +- libopagent/opagent.c | 40 +++++++++++++++++++++++++++----- libperf_events/operf_counter.cpp | 13 ++++++---- libperf_events/operf_mangling.cpp | 6 ++++- libperf_events/operf_process_info.cpp | 4 +- opjitconv/opjitconv.c | 13 ++++++++-- pe_profiling/operf.cpp | 7 +++++- pp/opreport.cpp | 7 +++-- 14 files changed, 97 insertions(+), 32 deletions(-) hooks/post-receive -- oprofile |