From: Andreas K. <kr...@li...> - 2011-11-04 08:20:47
|
On 11/03/2011 05:38 PM, Maynard Johnson wrote: > On 11/03/2011 10:44 AM, Andreas Krebbel wrote: >> On 11/03/2011 04:21 PM, Maynard Johnson wrote: >>> On 11/03/2011 6:56 AM, Andreas Krebbel wrote: >>>> This patch makes use of the event mechanism to allow for dynamic >>>> enabling and disabling of the System z hardware sampling facility with >>>> the OProfile user space tools. > > Patch committed with minor fixups as mentioned in my earlier reply. Please do a > fresh checkout from upstream git repo and verify everything is OK. Thanks! I did a few tests and it seems to work fine. However, could you please merge the patch below. It fixes a typo in one of the variables: >> I found a typo while looking at it. Could you please fix that one as well? >> --- a/utils/opcontrol >> +++ b/utils/opcontrol >> @@ -507,7 +507,7 @@ do_save_setup() >> if test "$XEN_RANGE"; then >> echo "XEN_RANGE=$XEN_RANGE">> $SETUP_FILE >> fi >> - if test "$S390_HW_SAMPLER" = "1" -a "$S390_HWSAMPLER_BUFSIZE" != "0"; then >> + if test "$S390_HW_SAMPLER" = "1" -a "$S390_HW_SAMPLER_BUFSIZE" != "0"; then >> echo "S390_HW_SAMPLER_BUFSIZE=$S390_HW_SAMPLER_BUFSIZE">> $SETUP_FILE >> fi >> SETUP_FILE="$SAVE_SETUP_FILE" >> Bye, -Andreas- |