From: Maynard J. <may...@us...> - 2011-03-09 15:48:37
|
On 03/08/2011 3:21 PM, Sheetal Sahasrabudhe wrote: > Hi Maynard, > > On Tue, March 8, 2011 11:48 am, Maynard Johnson wrote: >> Please verify to us that 'make distcheck' passes with this patch applied. > > 'make distcheck' succeeds with this patch applied but with GUI turned off. > I turned off the GUI by setting DISTCHECK_CONFIGURE_FLAGS as follows in Makefile. > DISTCHECK_CONFIGURE_FLAGS = --with-kernel-support --enable-gui=no > > If --enable-gui is left ON, then I get the following errors: > make[5]: Entering directory `oprofile-0.9.7git/_build/gui/ui' > o oprof_start.base.h ../../../gui/ui/oprof_start.base.ui > make[5]: o: Command not found > make[5]: [oprof_start.base.h] Error 127 (ignored) > o oprof_start.base.cpp -impl oprof_start.base.h ../../../gui/ui/oprof_start.base.ui > make[5]: o: Command not found > make[5]: [oprof_start.base.cpp] Error 127 (ignored) > g++ -DHAVE_CONFIG_H -I. -I../../../gui/ui -I../.. -W -Wall -fno-common -ftemplate-depth-50 -g -O2 -MT oprof_start.base.o -MD -MP -MF .deps/oprof_start.base.Tpo -c -o oprof_start.base.o oprof_start.base.cpp > g++: oprof_start.base.cpp: No such file or directory > g++: no input files > make[5]: *** [oprof_start.base.o] Error 1 > > > I didn't debug this further as it seemed to be completely unrelated to the patch. > Since the patch does not touch any GUI code, I hope that is acceptable. > Please let me know what you think. Right, your patch should have no impact on this. *Richard* (on cc) can review your patch without having a concern about that. I'm pretty sure the failure you see when you enable gui build is due to something Gert and I missed with the patch I committed on Feb 25 to enable oprofile gui parts to build with qt4. I tested the patch on a couple different distros, but apparently some circumstances can cause problems. *Gert*, any ideas off the top of your head? -Maynard > > Thanks, > Sheetal > |