From: John V. <sod...@gm...> - 2010-05-10 18:18:02
|
On Mon, May 10, 2010 at 1:05 PM, Andi Kleen <an...@fi...> wrote: > On Mon, May 10, 2010 at 12:07:25PM -0400, John Villalovos wrote: >> My personal opinion is that it would be less confusing to people to >> report it as "i386/nehalem" than as "i386/core_i7". Since Core i7 now >> encompasses Nehalem and Westmere microarchitecture processors. And >> likely in the future some Sandy Bridge microarchitecture processors >> will be called Core i7. > > Did you try it and does it work with existing user space? I just tried and it does NOT work with the userspace. I foolishly thought it looked at the directory structure in the event directory :( But of course it needs more info than that. After taking a quick look at the oprofile userspace code I'm guessing that the following should be updated: libop/op_cpu_type.c libop/op_cpu_type.h libop/op_events.c utils/ophelp.c So that would need to be done, well before updating the kernel. I would think we should leave "i386/core_i7" in there, but add in "i386/nehalem" so that we could switch the kernel in the future. |