[ oprofile-Bugs-2216012 ] open(..., O_CREAT|...) lacks third argument

[SourceForge.net <no...@so...>]

Bugs item #2216012, was opened at 2008-11-02 04:52
Message generated for change (Comment added) made by maynardj
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2216012&group_id=16191

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Maynard Johnson (maynardj)
Summary: open(..., O_CREAT|...) lacks third argument

Initial Comment:
OProfile-0.9.4

At line 47 in libutil++/file_manip.cpp there is a
open(destination.c_str(), O_RDWR|O_CREAT) system call.

This is incorrect: when used with O_CREAT, the open() system calls needs a third argument (file permissions creation mode). In other places in the source code this argument is 0644 (rw-r--r--).

This prevents oprofile-0.9.4 from compiling on Ubuntu 8.10 (there's a compile-time check for this).

dav...@fr...

----------------------------------------------------------------------

>Comment By: Maynard Johnson (maynardj)
Date: 2008-11-05 18:30

Message:
Fix committed to CVS.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2216012&group_id=16191