From: John L. <le...@mo...> - 2008-04-07 16:25:26
|
On Mon, Apr 07, 2008 at 05:42:20PM +0200, Daniel Hansel wrote: > - padding_count = (((rec->total_size + 7) & 7) ^ 7); > + /* padding bytes are calculated over the complete record > + * (i.e. header + symbol name + code) > + */ > + padding_count = (((sizeof(*rec) + strlen(entry->symbol_name) + 1 + entry->code_size + 7) & 7) ^ 7); Please use an intermediary variable for 'sizeof...code_size' instead of this super-long line. Also, maybe time for the & 7 stuff to become a macro wit a sensible name? cheers john |