Re: JIT_SUPPORT: patch for version info of opagent library

[John L. <le...@mo...>]

On Thu, Jan 31, 2008 at 05:20:50PM +0100, Daniel Hansel wrote:

> +__asm__(".symver op_major_version_1_0,op_major_version@OPAGENT_1.0");
> +__asm__(".symver op_minor_version_1_0,op_minor_version@OPAGENT_1.0");
> +
> +int op_major_version_1_0(void)
> +{
> +	return 1;
> +}
> +
> +int op_minor_version_1_0(void)
> +{
> +	return 0;
> +}

I don't think this is necessary, you can just leave out the asm and do
op_major/minor_version()

We only need this symver stuff when we have two symbols with the same
name but different implementations. We haven't even released 1.0 yet, so
that can't happen.

Otherwise looks fine

regards
john