Re: Patches for oparchive

[William C. <wc...@re...>]

Rob Bradford wrote:
> Attached are a couple of patches that we are using against our OProfile
> tree to improve oparchive.
> 
> 1.) The first fixes a bug in oparchive that results in the the debug
> data overwriting the executables themselves. The patch fixes this by
> always putting the debug data into a .debug subdirectory. 'opreport'
> will find it there so it doesn't really matter that it might have
> originally been in /usr/lib/debug.
> 
> 2.) The second adds a --list-files/-l option to oparchive that simply
> lists the files that would be copied rather than copying them.
> 
> We'd love to see these patches integrated so welcome feedback.
> 
> Cheers,
> 
> Rob

Hi Rob,

The first patch does prevent a possible overwrite of executable file. Are there 
concrete examples file name is being used for both the executable and the 
debuginfo file?

That case is the second patch patch useful? Note that it doesn't totally disable 
creation of file system. The first patch may create directories even if the -l 
option is being used. Documentation for the -l options for

-Will