From: John L. <le...@mo...> - 2005-02-08 00:53:05
|
On Mon, Feb 07, 2005 at 05:04:00PM -0700, Scott T Jones wrote: > This patch adds two new functions to OProfile. First, it adds the ability I've just spent a couple of minutes (literally: two minutes) look at the patch, and it looks pretty good. I'll try and find time for a proper, close review soon. One concern architecturally is your approach the fake ELF files. First, they need to get generated *permanently*: I could be running opreport two months after the profiler was running, on a different machine. What you need is to create them in /var/lib/oprofile/samples/{anon}/ or whatever. Second, getting opreport to write out the ELF files isn't good either, for the same reasons. Instead of these temporary ranges/entries files, can't that very same code be responsible for writing the ELF files? It could do this periodically or when it shuts down. Ideally, the pp tools shouldn't have to know *anything* about this stuff. Anyway, this looks encouraging. regards, john |