[Openvpn-devel] Re: Windows install pkg leaves a ; in path

[Mathias S. <ma...@ni...>]

On Sun, 13 Feb 2005, James Yonan wrote:

> On Sun, 13 Feb 2005, Mathias Sundman wrote:
>
>> When uninstalling OpenVPN, the installation package leaves a semicolon at
>> the end of the path.
>
> A bit ugly -- maybe we should fix RemoveFromPath?

Yes, you're right. Attached is a fixed version of setpath.nsi.

I first found a new version at the NSIS site which had this problem fixed, 
but that version seemed to have a broken StrStr function, so in some 
occations it wouldn't add any path at all.

I gave up bughunting that code and fixed the old one instead. I've done 
the following changes:

    Added code to remove the semicolon at the end of the path
    when uninstalling.

    Added code to make sure we don't insert an extra semicolon
    before our path if there already exist one at the end of
    the original path.

    Removed duplicated "un. and install" functions and made
    macros to duplicate the code instead.

Cheers - Mathias