[Openvpn-devel] Windows install pkg leaves a ; in path

[Mathias S. <ma...@ni...>]

When uninstalling OpenVPN, the installation package leaves a semicolon at 
the end of the path.

When OpenVPN is then re-installed, another semicolon is added to the path 
before the openvpn path, and you therefore end up with two semicolons 
before the OpenVPN path.

Every time you install a new version of OpenVPN an extra semicolon is 
added!

I have solved this in the OpenVPN GUI installation package simply by 
changing

   ; remove previously set path (if any)
   Push "$INSTDIR\bin"
   Call RemoveFromPath

to

   ; remove previously set path (if any)
   Push ";$INSTDIR\bin"
   Call RemoveFromPath

in the two places RemoveFromPath is called from the NSIS script.

I guess a more "correct" solution would be to fix the setpath.nsi 
RemoveFromPath function so it removes the preceding semicolon if a such 
exists.

Thanks to Markku Leinio for reporting this problem.

--
_____________________________________________________________
Mathias Sundman                  (^)   ASCII Ribbon Campaign
OpenVPN GUI for Windows           X    NO HTML/RTF in e-mail
http://openvpn.se                / \   NO Word docs in e-mail