[Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Disallow stdin as config unless user is authorized

[cron2 (C. Review) <ge...@op...>]

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1343?usp=email )

Change subject: openvpnserv: Disallow stdin as config unless user is authorized
......................................................................

openvpnserv: Disallow stdin as config unless user is authorized

Reported by: <st...@sr...>

Change-Id: I356faeebfade1eed9b40d6700b13621c357ec5ac
Signed-off-by: Selva Nair <sel...@gm...>
Acked-by: Gert Doering <ge...@gr...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1343
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg34156.html
Signed-off-by: Gert Doering <ge...@gr...>
---
M src/openvpnserv/validate.c
1 file changed, 5 insertions(+), 0 deletions(-)




diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c
index 2187fb5..ddaa381 100644
--- a/src/openvpnserv/validate.c
+++ b/src/openvpnserv/validate.c
@@ -68,6 +68,11 @@
     const WCHAR *config_file = NULL;
     WCHAR config_dir[MAX_PATH];
 
+    /* fname = stdin is special: do not treat it as a relative path */
+    if (wcscmp(fname, L"stdin") == 0)
+    {
+        return FALSE;
+    }
     /* convert fname to full path */
     if (PathIsRelativeW(fname))
     {

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1343?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I356faeebfade1eed9b40d6700b13621c357ec5ac
Gerrit-Change-Number: 1343
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <sel...@gm...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>