[Openvpn-devel] [XS] Change in openvpn[master]: iservice: fix DNS address list generation

[cron2 (C. Review) <ge...@op...>]

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1339?usp=email )

Change subject: iservice: fix DNS address list generation
......................................................................

iservice: fix DNS address list generation

While generating the address list string for the DNS server addresses,
to be set in the registry, the offset is calculated the wrong way. This
results in gaps between addresses after the first two.

Reported-By: aa...@sr...

Change-Id: I7252d5a252e91ffc03db142aa226c9eb1656480b
Signed-off-by: Heiko Hund <he...@is...>
Acked-by: Lev Stipakov <lst...@gm...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1339
Message-Id: <202...@gr...>
Signed-off-by: Gert Doering <ge...@gr...>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)




diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index 577d89c..58f1e02 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -1873,7 +1873,7 @@
             {
                 RtlIpv4AddressToStringA(&msg->addr[i].ipv4, addrs + offset);
             }
-            offset += strlen(addrs);
+            offset = strlen(addrs);
         }
 
         err = SetNameServers(iid, msg->family, addrs);

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1339?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7252d5a252e91ffc03db142aa226c9eb1656480b
Gerrit-Change-Number: 1339
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>