|
From: cron2 (C. Review) <ge...@op...> - 2025-11-03 13:14:33
|
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1341?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: manage: Correctly handle port 65535 in man_kill ...................................................................... manage: Correctly handle port 65535 in man_kill Commit c66d433111c958c42cc98f4ba12d3cfc1bd5b3b4 introduced an off-by-one when changing a literal to a constant. Github: fixes OpenVPN/openvpn#887 Change-Id: I19373408a82332d7b2e5c634e5509c8be3727b5a Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1341 Message-Id: <202...@gr...> Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/manage.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/1341/2 diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index e46b5f2..6efa100 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -612,7 +612,7 @@ : (streq(p1, "udp")) ? PROTO_UDP : PROTO_NONE; - if ((port > 0 && port < UINT16_MAX) && (proto != PROTO_NONE)) + if ((port > 0 && port <= UINT16_MAX) && (proto != PROTO_NONE)) { n_killed = (*man->persist.callback.kill_by_addr)(man->persist.callback.arg, addr, (uint16_t)port, proto); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1341?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I19373408a82332d7b2e5c634e5509c8be3727b5a Gerrit-Change-Number: 1341 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> |