[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

[MaxF (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email )

Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
Tiny bug in the error message, but the change makes sense.

What I don't understand is how this gets triggered. I looked at configure.ac again and as far as I understand it, it does the following (starting from line 1041):

Set have_export_keying_material to "yes".
Check if mbedtls_ssl_conf_export_keys_ext_cb exists.
If not, check if mbedtls_ssl_set_export_keys_cb exists.
If that doesn't exist either, set have_export_keying_material to "no".


File src/openvpn/ssl_mbedtls.c:

http://gerrit.openvpn.net/c/openvpn/+/920/comment/1220b775_cb2a77f6 :
PS1, Line 257: HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB
The second one should be HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/920?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0
Gerrit-Change-Number: 920
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-CC: MaxF <ma...@ma...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Thu, 27 Mar 2025 15:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment