[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

[d12fk (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )

Change subject: dns: apply settings via script on unixoid systems
......................................................................


Patch Set 10:

(3 comments)

File distro/dns-scripts/systemd-dns-updown.sh:

http://gerrit.openvpn.net/c/openvpn/+/838/comment/48ccf623_85a0324a :
PS9, Line 75: =~
> This broken now. […]
Good catch


http://gerrit.openvpn.net/c/openvpn/+/838/comment/9f07bc79_ffc94f9f :
PS9, Line 75: "$
> Maybe we could add a comment here like: "Add as a routing-only domain (~ prefix) unless already conf […]
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/838/comment/172c246a_ae95ab11 :
PS9, Line 116:         [ -n "${!transport_var}" -a "${!transport_var}" = "DoH" ] || break
> I think this line could use a comment like "skip DoH dns entries", otherwise it takes a while to und […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10
Gerrit-Change-Number: 838
Gerrit-PatchSet: 10
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Thu, 06 Mar 2025 12:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@li...>
Gerrit-MessageType: comment