[Openvpn-devel] [PATCH applied] Re: Fix port-share journal doc

[Gert D. <ge...@gr...>]

Acked-by: Gert Doering <ge...@gr...>

Neither the code nor the manpage are particularily easy to digest, but
after staring at the code for quite a bit I have to agree with your
manpage fix.  The "to" bit goes into the filename...

  && !getsockname(cp->sd, (struct sockaddr *) &to.addr.sa, &dlen))
..
     const char *t = print_openvpn_sockaddr(&to, &gc);
     fnlen =  strlen(journal_dir) + strlen(t) + 2;
     snprintf(jfn, fnlen, "%s/%s", journal_dir, t);


.. and the "from" bit into the file content.

     if (!getpeername(pc->sd, (struct sockaddr *) &from.addr.sa, &slen)
..
     const char *f = print_openvpn_sockaddr(&from, &gc);
     if (write(fd, f, strlen(f)) != strlen(f))


Your patch has been applied to the master and release/2.6 branch (bugfix).

commit 9343cd101d74377305b96cd501b8659f64c70e46 (master)
commit 6d64fa4bfff935eb82f9786f709126ab02f0d8b3 (release/2.6)
Author: corubba
Date:   Sun Dec 8 00:19:35 2024 +0100

     Fix port-share journal doc

     Signed-off-by: corubba <co...@gm...>
     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <d7c...@gm...>
     URL: https://www.mail-archive.com/ope...@li.../msg30036.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering