[Openvpn-devel] [M] Change in openvpn[master]: Ensures all params are ready before invoking dco_set_peer()

[stipa (C. Review) <ge...@op...>]

Attention is currently required from: its_Giaan, plaisthos.

stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/587?usp=email )

Change subject: Ensures all params are ready before invoking dco_set_peer()
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Patchset:

PS4: 
Please note that in case of (Windows) client dco_set_peer() is now calling twice. Once, as before, in 

  do_up()->p2p_set_dco_keepalive()
  
and another one in

  do_up()->do_deferred_options_part2()->tls_session_update_crypto_params()

Is the problem solved by this patch is server-specific? Maybe ensure that dco_set_peer() call inside do_deferred_p2p_ncp() is called only for server? Note that existing code also works in P2P without --pull.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/587?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic8538e734dba53cd43fead3961e4401c8037e079
Gerrit-Change-Number: 587
Gerrit-PatchSet: 4
Gerrit-Owner: its_Giaan <gia...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: its_Giaan <gia...@ma...>
Gerrit-Comment-Date: Wed, 24 Jul 2024 11:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment