[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: Add test_ssl unit test and test export of PEM to file
......................................................................


Patch Set 3: Code-Review-2

(1 comment)

Patchset:

PS3: 
this fails the GHA mingw builds with

```
  /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c: In function ‘crypto_pem_encode_certificate’:
  Error: /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c:112:5: error: implicit declaration of function ‘backend_x509_write_pem’ [-Werror=implicit-function-declaration]
    112 |     backend_x509_write_pem(cert, tmpfile);
        |     ^~~~~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
```

(see https://github.com/cron2/openvpn/actions/runs/7365003797/job/20045892888) so it can't go in yet.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Comment-Date: Sat, 30 Dec 2023 16:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment