[Openvpn-devel] [S] Change in openvpn[master]: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/454?usp=email )

Change subject: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/route.c:

http://gerrit.openvpn.net/c/openvpn/+/454/comment/ffdd8937_e4a1e87d :
PS2, Line 3703:                      * Since we only copied 32 bytes from cp to ifr but sdl
> If ifr_addr. […]
Ah, no, it's not that easy.  The code above does some arithmetics with len=...+max(), but then doesn't actually memcpy(..., len) bytes but sizeof(ifr).

Need to think through this again.  But however, the comments need work to be understandable for mere mortals :-)



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/454?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia797c8801fa9a9bc10b6674efde5fdbd7132e4a8
Gerrit-Change-Number: 454
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Comment-Date: Sat, 30 Dec 2023 15:46:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <ge...@gr...>
Gerrit-MessageType: comment