[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

[flichtenheld (C. Review) <ge...@op...>]

Attention is currently required from: MaxF, plaisthos.

flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email )

Change subject: Enable key export with mbed TLS 3.x.y
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File src/openvpn/ssl_mbedtls.c:

http://gerrit.openvpn.net/c/openvpn/+/402/comment/0824b00d_51b5d999 :
PS3, Line 202: mbedtls_ssl_export_keys_cb(void *p_expkey,
This needs a comment what is going on. The differences between the two variants are way to small to be able to see them easily. So there should be documentation on what they are and why they are necessary. At the very least it should explicitly reference the functions these are used as callback arguments to.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8e90530726b7f7ba3cee0438f2d81a1ac42e821b
Gerrit-Change-Number: 402
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <ma...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: MaxF <ma...@ma...>
Gerrit-Comment-Date: Mon, 13 Nov 2023 12:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment