|
From: cron2 (C. Review) <ge...@op...> - 2023-11-09 11:37:32
|
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/374?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove CMake custom compiler flags for RELEASE and DEBUG build ...................................................................... Remove CMake custom compiler flags for RELEASE and DEBUG build This overwrites the default that cmake automatically sets. In the case of debug builds, this breaks debugging as -O1 already optimises many variables away. Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac Acked-by: Frank Lichtenheld <fr...@li...> Message-Id: <202...@li...> URL: https://www.mail-archive.com/search?l=mid&q=2...@li... Signed-off-by: Gert Doering <ge...@gr...> --- M CMakeLists.txt 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/374/2 diff --git a/CMakeLists.txt b/CMakeLists.txt index 376a060..d21c9bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -79,10 +79,6 @@ add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>") endif() else () - set(CMAKE_C_FLAGS_RELEASE "-O2") - set(CMAKE_CXX_FLAGS_RELEASE "-O2") - set(CMAKE_C_FLAGS_DEBUG "-g -O1") - set(CMAKE_CXX_FLAGS_DEBUG "-g -O1") add_compile_options(-Wall -Wuninitialized) check_c_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/374?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac Gerrit-Change-Number: 374 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arn...@rf...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: newpatchset |