[Openvpn-devel] Re: [PATCH - 2 of 4] minimal change to PUSH_DEFINED

[Neil B. <ne...@cs...>]

On Tuesday July 27, ji...@yo... wrote:
> PUSH_DEFINED is currently unused, so overall I don't have any problem with
> this.  Probably when something gets written that needs PUSH_DEFINED, the
> subtletes of how it should operate will become more apparent.
> 

It was used in beta6 which is what I was working on when I found the
need for this patch. 
In options_string, it read:
  if (tt && !PUSH_DEFINED(o) && !PULL_DEFINED(o))
    {
      const char *ios = ifconfig_options_string (tt, remote, o->ifconfig_nowarn, gc);
      if (ios && strlen (ios))
	buf_printf (&out, ",ifconfig %s", ios);
    }

beta7 reads
  if (tt && o->mode == MODE_POINT_TO_POINT && !PULL_DEFINED(o))
    {
      const char *ios = ifconfig_options_string (tt, remote, o->ifconfig_nowarn, gc);
      if (ios && strlen (ios))
	buf_printf (&out, ",ifconfig %s", ios);
    }

which may well be fixing the same problem that I saw.

NeilBrown