Re: [Openvpn-devel] [PATCH v3 3/4] Check if the -wrap argument is actually supported by the platform's ld

[Frank L. <fr...@li...>]

On Wed, Jul 12, 2023 at 11:55:29AM +0200, Arne Schwabe wrote:
> This avoids build errors on macOS. Also the test_tls_crypt command works
> just fine on FreeBSD with its linkers, so do not make that test Linux only.
> 
> Patch v2: allow running with old cmake version (cmake 3 on RHEL7 with EPEL
>           is only 3.17)
> Patch v3: add OPTIONAL keyword to Incldue required by some cmake versions

Yeah, I also have no idea why you didn't need that for your CMake. Anyway,
it is correct according to the documentation. And it is definitely required
on Ubuntu 20.04.

Tested on Ubuntu 20.04 (cmake 3.16.3), Ubuntu 22.04 (cmake 3.22.1), and
checked build results for GHA.

Acked-by: Frank Lichtenheld <fr...@li...>

> Change-Id: Id26676bdc576c7d3d6726afa43fe6c7a397c579b
> Signed-off-by: Arne Schwabe <ar...@rf...>
> ---
>  CMakeLists.txt | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

-- 
  Frank Lichtenheld