[Openvpn-devel] [PATCH applied] Re: Add tests for finding certificates in Windows cert store

[Gert D. <ge...@gr...>]

Acked-by: Gert Doering <ge...@gr...>

Code looks reasonable and tests what we want tested.  Tested with
a local MinGW build -> copied to windows10, and with GHA.

    [==========] Running 5 test(s).
    [ RUN      ] test_parse_hexstring
    [       OK ] test_parse_hexstring
    [ RUN      ] import_certs
    [       OK ] import_certs
    [ RUN      ] test_find_cert_bythumb
    [       OK ] test_find_cert_bythumb
    [ RUN      ] test_find_cert_byname
    [       OK ] test_find_cert_byname
    [ RUN      ] test_find_cert_byissuer
    [       OK ] test_find_cert_byissuer
    [==========] 5 test(s) run.
    [  PASSED  ] 5 test(s).

Your patch has been applied to the master and release/2.6 branch.

commit b538a334284716757c48026bf6ace95e33258943 (master)
commit a08d0c770d0c0cd2534a0a900bba358b1c44056f (release/2.6)
Author: Selva Nair
Date:   Tue Mar 14 21:35:14 2023 -0400

     Add tests for finding certificates in Windows cert store

     Signed-off-by: Selva Nair <sel...@gm...>
     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <202...@gm...>
     URL: https://www.mail-archive.com/ope...@li.../msg26415.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering