[Openvpn-devel] [PATCH applied] Re: Fix memory leaks in HMAC initial packet id

[Gert D. <ge...@gr...>]

Acked-by: Gert Doering <ge...@gr...>

Stared at the code, and the current version looks good - the change
is now bigger than "just add a free_buf()", but since that did not
work, the new approach of putting all buffers into the per-session
gc_arena should stop the leaking (it might use a bit more memory
while the session is active, because there are two bufs of 1600 bytes
each, but it will be returned afterwards << this is the good part)

The biggest part of this patch is the unit test anyway :-)

Subjected this to Github actions (which broke the previous two versions)
and to my server testbed (which broke v2).  All are happy now.

Your patch has been applied to the master and release/2.6 branch.

commit e8ecaadd2ac38f2c2d4bcd40eeaea7401aa737a1 (master)
commit 0942e1575abbc0bdda62e3158827b130ae3f9ab6 (release/2.6)
Author: Arne Schwabe
Date:   Wed Mar 15 20:55:12 2023 +0100

     Fix memory leaks in HMAC initial packet id

     Signed-off-by: Arne Schwabe <ar...@rf...>
     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <202...@rf...>
     URL: https://www.mail-archive.com/search?l=mid&q=2...@rf...
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering