Re: [Openvpn-devel] [PATCH 0/4] Add some tests for cryptoapi.c functions

[Selva N. <sel...@gm...>]

On Wed, Mar 15, 2023 at 4:30 AM Gert Doering <ge...@gr...> wrote:

> Hi,
>
> On Tue, Mar 14, 2023 at 09:35:12PM -0400, sel...@gm... wrote:
> > From: Selva Nair <sel...@gm...>
> >
> >   Import some sample certificates into Windows store for testing
> >     - 4 test certificates&keys imported to user store
> >       and removed at the end.
> [..]
>
> This is extremely valuable.  Thanks.
>
> If I apply these 4 patches on top of "master", will the test then succeed,
> or will it show failure due to the not-yet-merged padding patch?
>

As cryptoapi works correctly without the padding patch (only PKCS11 was
affected), and this tests only exercises those bits should work without the
padding patch. Though I tested it only with both included.

Selva