[Openvpn-devel] [PATCH applied] Re: Always include ACKs for the last seen control packets

[Gert D. <ge...@gr...>]

Applying Frank's ACK on v1 to v2, since the code is the same - just
context changes, and renaming of lru to mru.

Ran through server and client side testing, all works.

This also adds a unit test, which is very welcome :-) - complex stuff,
this, and not really easy to test ("I need to drop ACK #3 of the
handshake to see if the other end will do a retransmit or if it is
ACKed en passant with the next packet").

Stared a bit at the code, and while I'm not sure I understand all
details of the reliable code well enough, the parts that I *do* understand
look reasonable enough (and no memory-unsafe stuff etc).

Your patch has been applied to the master branch.

(I will push this together with 29/28)

commit c879609534e455471bc1e8091c78cbd9427d402b
Author: Arne Schwabe
Date:   Wed Aug 31 15:41:39 2022 +0200

     Always include ACKs for the last seen control packets

     Signed-off-by: Arne Schwabe <ar...@rf...>
     Acked-by: Frank Lichtenheld <fr...@li...>
     Message-Id: <202...@rf...>
     URL: https://www.mail-archive.com/ope...@li.../msg25143.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering