Re: [Openvpn-devel] [PATCH] include unistd.h for _exit(2) declaration

[Gert D. <ge...@gr...>]

Hi,

On Fri, May 27, 2022 at 01:34:11PM +0200, Heiko Hund wrote:
> Signed-off-by: Heiko Hund <he...@is...>
> ---
>  src/openvpn/error.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/openvpn/error.h b/src/openvpn/error.h
> index 972619fe..76308560 100644
> --- a/src/openvpn/error.h
> +++ b/src/openvpn/error.h
> @@ -33,6 +33,8 @@
>  
>  #if _WIN32
>  #include <windows.h>
> +#else
> +#include <unistd.h>
>  #endif
>  
>  /* #define ABORT_ON_ERROR */

<unistd.h> is included by "syshead.h" already today, with a nice
HAVE_UNISTD_H wraper (thus, not depending on a "if it's not WIN32,
it surely must have unistd.h" assumption).

So I wonder what issue this fixes?  I see no compile time warnings about
_exit() either.

gert


-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...