Re: [Openvpn-devel] [PATCH 22/28] Implement HMAC based session id for tls-crypt v2

[Frank L. <fr...@li...>]

> Frank Lichtenheld <fr...@li...> hat am 29.04.2022 15:11 geschrieben:
> > Arne Schwabe <ar...@rf...> hat am 22.04.2022 16:29 geschrieben:
[...]
> > diff --git a/tests/unit_tests/openvpn/test_pkt.c b/tests/unit_tests/openvpn/test_pkt.c
> > index c4e23521d..184b88383 100644
> > --- a/tests/unit_tests/openvpn/test_pkt.c
> > +++ b/tests/unit_tests/openvpn/test_pkt.c
> > @@ -531,7 +531,7 @@ test_generate_reset_packet_plain(void **ut_state)
> >  
> >      uint8_t header = 0 | (P_CONTROL_HARD_RESET_CLIENT_V2 << P_OPCODE_SHIFT);
> >  
> > -    struct buffer buf = tls_reset_standalone(&tas, &client_id, &server_id, header);
> > +    struct buffer buf = tls_reset_standalone(&tas, &client_id, &server_id, header, 0, 0);
> 
> Nitpick: the second 0 should be "false" instead. Same for all further calls in this file.

Note: fixed in 23/28

Regards,
--
Frank Lichtenheld