Re: [Openvpn-devel] [PATCH v2] Implement constructing a control channel reset client as standalone fucntion

[Frank L. <fr...@li...>]

Some small issues Gert might decide to fix on apply:

Typo "fucntion" in summary line of commit message.

> Arne Schwabe <ar...@rf...> hat am 28.04.2022 00:34 geschrieben:
> This implement creating a reset packet without needing to setup a full control

"implements"

> session.
[...]
> diff --git a/src/openvpn/ssl_pkt.c b/src/openvpn/ssl_pkt.c
> index 7233871b1..a93027505 100644
> --- a/src/openvpn/ssl_pkt.c
> +++ b/src/openvpn/ssl_pkt.c
[...]
> +    /* Add tls-auth/tls-crypt wrapping, this might replace buf */
> +    tls_wrap_control(&tas->tls_wrap, header, &buf, own_sid);
> +
> +    return buf;
> +}
> +

git am complains about "new blank line at EOF."

> diff --git a/src/openvpn/ssl_pkt.h b/src/openvpn/ssl_pkt.h
> index b7a8d9c35..dd9361407 100644
> --- a/src/openvpn/ssl_pkt.h
> +++ b/src/openvpn/ssl_pkt.h
[...]
> @@ -157,6 +163,19 @@ read_control_auth(struct buffer *buf,
>                    const struct link_socket_actual *from,
>                    const struct tls_options *opt);
>  
> +
> +/**
> + * This function creates a reset packet using the information
> + * from the tls pre decrypt state.
> + *
> + * The returned buf need to be free with \c free_buf

"needs"

Regards,
--
Frank Lichtenheld