Re: [Openvpn-devel] [PATCH 17/28] Implement constructing a control channel reset client as standalone fucntion

[Gert D. <ge...@gr...>]

Hi,

On Wed, Apr 27, 2022 at 06:43:31PM +0200, Gert Doering wrote:
> [  ERROR   ] --- ASSERT: buf_write(&buf, &net_pid, sizeof(net_pid))
> [   LINE   ] --- ../../../../openvpn/src/openvpn/ssl_pkt.c:425: error: Failure!
> [  FAILED  ] test_generate_reset_packet_tls_auth

It needs this hunk from 18/28

+struct tls_auth_standalone
+init_tas_auth(int key_direction)
 { 
     struct tls_auth_standalone tas = { 0 };
+    struct frame frame = { {.headroom = 200, .payload_size = 1400}, 0};   
+    tas.frame = frame;

... and then the tests pass.  (This is not really surprising, as it
fails buf_write() == the buffer is too small, and without .payload_size,
it will be zero-sized...)

Can you move that one over, rebase, and send 17 v2 + 18 v2?  (18 will
also benefit from rebasing to partially already whitespace-fixed master)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...