Re: [Openvpn-devel] [PATCH 17/28] Implement constructing a control channel reset client as standalone fucntion

[Gert D. <ge...@gr...>]

Hi,

On Fri, Apr 22, 2022 at 04:29:42PM +0200, Arne Schwabe wrote:
> This implement creating a reset packet without needing to setup a full control
> session.

I was about to merge this, with "it has a unit test, so what could
go wrong".

But...

[ RUN      ] test_generate_reset_packet_plain
[       OK ] test_generate_reset_packet_plain
[ RUN      ] test_generate_reset_packet_tls_auth
[  ERROR   ] --- ASSERT: buf_write(&buf, &net_pid, sizeof(net_pid))
[   LINE   ] --- ../../../src/openvpn/ssl_pkt.c:425: error: Failure!
[  FAILED  ] test_generate_reset_packet_tls_auth

Gentoo/OpenSSL 1.1.1n build

[  ERROR   ] --- ASSERT: 
[   LINE   ] --- ../../../../openvpn/src/openvpn/ssl_pkt.c:425: error: Failure!
[  FAILED  ] test_generate_reset_packet_tls_auth

Gentoo/mbedTLS build (with --enable-small, thus, no message)

[  ERROR   ] --- ASSERT: buf_write(&buf, &net_pid, sizeof(net_pid))
[   LINE   ] --- ../../../../openvpn/src/openvpn/ssl_pkt.c:425: error: Failure!
[  FAILED  ] test_generate_reset_packet_tls_auth

FreeBSD/OpenSSL 1.1.1l build


Could you have a look?

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...