Re: [Openvpn-devel] [RFC 8/8] ovpn-dco: force user to set DCO_INCLUDEDIR

[Antonio Q. <a...@un...>]

Hi,

On 29/12/2021 14:34, Gert Doering wrote:
> Hi,
> 
> On Tue, Dec 07, 2021 at 01:11:37PM +0100, Antonio Quartulli wrote:
>> Signed-off-by: Antonio Quartulli <a...@un...>
>> ---
>>   configure.ac | 32 ++++++++++----------------------
>>   1 file changed, 10 insertions(+), 22 deletions(-)
> 
> I think this should be squashed into the first patch, that adds DCO
> support to configure.ac in the first place.
> 

Yeah, this is done already.

> Plus, I wonder how we should do this in the first place - if we want
> widespread DCO adoption, maybe we should include the necessary header
> file into the openvpn community tree, and always compile "with DCO"
> on Linux (if libnl is available)?
> 
> Having to fiddle with an extra library dependency *and* "you need this
> header file which is found elsewhere" feels extra clumsy...
> 
> Alternatively, maybe linuxdco should just install the header file when
> installing the kernel module?  How's this typically done for other
> kernel modules that expose an API that needs a header file?
> 

Normally the required header is just shipped with the program itself 
(i.e. check the 'iw' program which comes with its own copy of 'nl80211.h').

Being this API forward compatible, it won't hurt if our header is 
slightly out-of-date.

Ideally, when DCO will be upstream, the header will be installed 
automatically along with other kernel headers. But we still can't assume 
they are installed, hence it's just easier to ship the header with the 
OpenVPN source code.

I'd just do that at the end.

Regards,


-- 
Antonio Quartulli