Re: [Openvpn-devel] [RFC 8/8] ovpn-dco: force user to set DCO_INCLUDEDIR

[Gert D. <ge...@gr...>]

Hi,

On Tue, Dec 07, 2021 at 01:11:37PM +0100, Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <a...@un...>
> ---
>  configure.ac | 32 ++++++++++----------------------
>  1 file changed, 10 insertions(+), 22 deletions(-)

I think this should be squashed into the first patch, that adds DCO
support to configure.ac in the first place.

Plus, I wonder how we should do this in the first place - if we want
widespread DCO adoption, maybe we should include the necessary header
file into the openvpn community tree, and always compile "with DCO"
on Linux (if libnl is available)?

Having to fiddle with an extra library dependency *and* "you need this
header file which is found elsewhere" feels extra clumsy...

Alternatively, maybe linuxdco should just install the header file when
installing the kernel module?  How's this typically done for other
kernel modules that expose an API that needs a header file?

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...