[Openvpn-devel] [PATCH applied] Re: networking: add and implement net_addr_ll_set() API

[Gert D. <ge...@gr...>]

Acked-by: Gert Doering <ge...@gr...>

This basically does not give me much to test, as it just adds functions 
that are not called yet.  Those look reasonable, and the result passes
compilation on Linux and FreeBSD.

I do not like the "MAC_FMT" bit very much - it looks like "yeah, I saw
this in another project, and it looks cool", but it introduces an extra
"what is it doing here?" for the two cases where it is used (and the
extra _STRINGIFY() does not help make it easier to follow).  But we
discussed this on IRC, and seems we need to disagree here...

NOTE: I accidentially pushed out v1 of the patch, with the "wrong"
brackets.  We'll sort this out.

NOTE2: this is a bugfix (omission), so it is intended to go to 
release/2.5 as well - but with the wrong patch merged to master, I
think I'll just get them all in, and then squash together the 3
patches into a single one for 2.5.

Your patch has been applied to the master branch.

commit 98f524cbd58d24d09dee26160d7386d710c3564f
Author: Antonio Quartulli
Date:   Fri Sep 3 18:11:12 2021 +0200

     networking: add and implement net_addr_ll_set() API

     Signed-off-by: Antonio Quartulli <a...@un...>
     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <202...@un...>
     URL: https://www.mail-archive.com/ope...@li.../msg22792.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering