Re: [Openvpn-devel] [PATCH 2/2] Also announce IV_CIPHERS as client in OpenVPN 2.4

[Arne S. <ar...@rf...>]

> +++ b/src/openvpn/ssl.c
> @@ -2311,7 +2311,18 @@ push_peer_info(struct buffer *buf, struct tls_session *session)
>          if (session->opt->ncp_enabled
>              && (session->opt->mode == MODE_SERVER || session->opt->pull))
>          {
> +            /* We keep announcing IV_NCP=2 in OpenVPN 2.4 even though it is
> +             * technically wrong to ensure not to break 2.4 setups on a
> +             * minor release */
>              buf_printf(&out, "IV_NCP=2\n");
> +            buf_printf(&out, "IV_CIPHERS=%s", session->opt->config_ncp_ciphers);
> +            if (!tls_item_in_cipher_list(session->opt->config_ciphername,
> +                                         session->opt->config_ncp_ciphers))
> +            {
> +                buf_printf(&out, ":%s", session->opt->config_ciphername);
> +            }
> +            buf_printf(&out, "\n")

This line misses a ';' at the end :(

I forgot this amending. I can resend the patch if needed.

Arne