Re: [Openvpn-devel] [PATCH 1/2] Unified success messages for setting mtu

[Gert D. <ge...@gr...>]

Hi,

On Mon, Jun 29, 2020 at 09:09:29PM +0200, Christopher Schenk wrote:
> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
> index 18cdf38d..3ef79b2f 100644
> --- a/src/openvpn/tun.c
> +++ b/src/openvpn/tun.c
> @@ -251,7 +251,7 @@ do_set_mtu_service(const struct tuntap *tt, const short family, const int mtu)
>      }
>      else
>      {
> -        msg(M_INFO, "%s MTU set to %d on interface %d using service", family_name, mtu, mtu_msg.iface.index);
> +        msg(M_INFO, "%s MTU set to %d on interface %d using SetIpInterfaceEntry()", family_name, mtu, mtu_msg.iface.index);
>          ret = true;
>      }

While I do like unified messages, this is not exactly what I had in mind
- the "using service" bit should stay, if using the service :-) - too
much unification.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...