Re: [Openvpn-devel] [PATCH] Move keying material exporter check from syshead.h to configure.ac

[Steffan K. <ste...@fo...>]

On 20-01-2020 13:42, Lev Stipakov wrote:
>     +       have_export_keying_material="yes"
>     +       AC_CHECK_FUNCS(
>     +               [SSL_export_keying_material],
>     +               ,
>     +               [have_export_keying_material="no"; break]
>     +       )
> 
> 
> Just wondering why not AC_CHECK_FUNC? In this case we could get rid of
> "break".
> 
> _FUNCS also defines HAVE_function macro, which we don't use in this
> particular case.
> 
> Noticed that we have similar code above:
> 
>     have_crypto_aead_modes="yes"
>     AC_CHECK_FUNCS(
>         [EVP_aes_256_gcm],
>         ,
>         [have_crypto_aead_modes="no"; break]
>     )
> 
> so maybe that's why.

This. It's too long ago that I fully remember, but I recall we changed
to FUNCS for some reason in the past. Autoconf is full of surprises. So
if we have something that works, and I want something similar, let's do
it in the exact same way.

-Steffan