Re: [Openvpn-devel] [PATCH] openssl: Replace not[Before/After] functions with get0 variants

[Gert D. <ge...@gr...>]

Hi,

On Wed, Mar 27, 2019 at 02:56:26PM -0700, Rosen Penev wrote:
> Also removed initialization with OpenSSL 1.1 as it is no longer needed and
> causes compilation errors when disabling deprecated APIs.
> 
> Same with SSL_CTX_set_ecdh_auto as it got removed.

The Subject: line is a bit misleading - shouldn't this be more something
like "Avoid calling deprecated-API calls of OpenSSL 1.1" or similar?

(People *do* look at commit logs, and the current subject does not cover
making the SSL_library_init() call conditional, etc.)

On the patch itself, I have no strong opinion and would welcome a review
from Steffan or Arne :-) - the Subject: line I can fix at commit time.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...