[Openvpn-devel] [PATCH applied] Re: Fix error message when using RHEL init script

[Gert D. <ge...@gr...>]

Acked-by: Gert Doering <ge...@gr...>

Whatever the future might bring for this script (like "going away in 
favour of systemd units"), this is a reasonable fix for now - never 
rely on shell variables to be non-empty in script comparisons.

Your patch has been applied to the master and release/2.4 branch.

As a side note: please use "git send-email" to avoid your patch getting
broken by your mail client (it was whitespace-massacred so needed manual
adjustment) and use "git commit -s" so we have a proper signed-off-by:
line.  No hard requirements for a mini-fix, but for the next and bigger
one you'll hopefully send one day :-)


commit 7e711035f12a25199c3a04193ee4e22e43930f6a (master)
commit d18fa4aab1b73074d71a4d8cbf894c73c689d2ec (release/2.4)
Author: Richard van den Berg via Openvpn-devel
Date:   Fri Dec 21 07:43:28 2018 +0100

     Fix error message when using RHEL init script

     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <c04...@vd...>
     URL: https://www.mail-archive.com/ope...@li.../msg18057.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering