Re: [Openvpn-devel] [PATCH] travis-ci: enable ccache for osx and mingw builds

[Илья Ш. <chi...@gm...>]

2017-12-30 16:19 GMT+05:00 Steffan Karger <st...@ka...>:

> Hi,
>
> Sorry for taking so long to respond.
>
> On 21-11-17 07:36, Ilya Shipitsin wrote:
> > --
> > ccache was now tested by me and works for osx
> > and mingw builds as well
>
> By how much does this improve build times?  I'm asking, because I
>

I noticed 1-2 minutes speedup on osx builds. however, it might be
due to brew slowness


> recently noticed that brew on the osx slaves takes a serious amount of
> time.  So I was wondering if we shouldn't try to avoid any brew
> operations for the osx builds.
>

I will add brew to travis-ci cache in "v2"

ccache itself seem to add about zero speedup (and definetly no speedup on
mingw builds)


>
> > ---
> >  .travis.yml           |  2 +-
> >  .travis/build-deps.sh | 14 ++++++--------
> >  2 files changed, 7 insertions(+), 9 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 366e6599..8efb1cbd 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -88,7 +88,7 @@ cache:
> >
> >  before_install:
> >    - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then brew update     ; fi
> > -  - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then brew install lzo; fi
> > +  - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then brew install lzo ccache; fi
>
> Before adding ccache here, we could reduce the build time by three
> minutes using --disable-lzo.
>
> >
> >  install:
> >    - if [ ! -z "${CHOST}" ]; then unset CC; fi
> > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh
> > index e787abab..001565f3 100755
> > --- a/.travis/build-deps.sh
> > +++ b/.travis/build-deps.sh
> > @@ -130,15 +130,13 @@ build_openssl () {
> >      fi
> >  }
> >
> > -# Enable ccache
> > -if [ "${TRAVIS_OS_NAME}" != "osx" ] && [ -z ${CHOST+x} ]; then
> > -    # ccache not available on osx, see:
> > -    # https://github.com/travis-ci/travis-ci/issues/5567
> > -    # also ccache not enabled for cross builds
> > -    mkdir -p "${HOME}/bin"
> > -    ln -s "$(which ccache)" "${HOME}/bin/${CC}"
> > -    PATH="${HOME}/bin:${PATH}"
> > +mkdir -p "${HOME}/bin"
> > +if [ -z ${CHOST+x} ]; then
> > +        ln -s "$(which ccache)" "${HOME}/bin/${CC}"
> > +else
> > +        ln -s "$(which ccache)" "${HOME}/bin/${CHOST}-cc"
> >  fi
> > +PATH="${HOME}/bin:${PATH}"
> >
> >  if [ ! -z ${CHOST+x} ]; then
> >        #
> >
>
> Code-wise the patch looks good.  But curious about your thought on the
> above.
>
> -Steffan
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Openvpn-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>