Re: [Openvpn-devel] [PATCH] travis: use clang's -fsanitize=address to catch more bugs

[Antonio Q. <a...@un...>]

Hi,

On 29/12/17 18:58, Steffan Karger wrote:
> On 29-12-17 11:32, Antonio Quartulli wrote:
>> On 29/12/17 18:00, Steffan Karger wrote:
>>> On 29-12-17 10:47, Steffan Karger wrote:
>>>> The clang address sanitizer is able to catch quite a number of 
>>>> memory-related bugs, such add memory leaks and buffer
>>>> under/overruns. So, enable the address sanitizer for one
>>>> openssl and one mbedtls build.
>>>>
>>>> This would have caught the buffer list unittest memory leak
>>>> that <151...@ka...>
>>>> wants to fix.
>>>
>>> For reference, I've pushed this commit to my own gh fork.  This
>>> would be the result based on current master: 
>>> https://travis-ci.org/syzzer/openvpn/builds/322839893\
> 
>> your travis build is failing and throwing out quite some "errors".
> 
>> I personally think we should fix them all before adding the new
>> sanitize flag, otherwise travis will just always fail until we fix
>> them all.
> 
> You already ACK'ed the fix in
> <151...@ka...> ;-)
> 
> But yeah, it would be nice to apply that fix before this patch.

woops, I didn't realize it was only that one :)
Even better!

Cheers,

-- 
Antonio Quartulli