Re: [Openvpn-devel] [PATCH] travis: use clang's -fsanitize=address to catch more bugs

[Steffan K. <ste...@fo...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 29-12-17 11:32, Antonio Quartulli wrote:
> On 29/12/17 18:00, Steffan Karger wrote:
>> On 29-12-17 10:47, Steffan Karger wrote:
>>> The clang address sanitizer is able to catch quite a number of 
>>> memory-related bugs, such add memory leaks and buffer
>>> under/overruns. So, enable the address sanitizer for one
>>> openssl and one mbedtls build.
>>> 
>>> This would have caught the buffer list unittest memory leak
>>> that <151...@ka...>
>>> wants to fix.
>> 
>> For reference, I've pushed this commit to my own gh fork.  This
>> would be the result based on current master: 
>> https://travis-ci.org/syzzer/openvpn/builds/322839893\
> 
> your travis build is failing and throwing out quite some "errors".
> 
> I personally think we should fix them all before adding the new
> sanitize flag, otherwise travis will just always fail until we fix
> them all.

You already ACK'ed the fix in
<151...@ka...> ;-)

But yeah, it would be nice to apply that fix before this patch.

- -Steffan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJaRh/bAAoJEEEwndWOY1w5kFQH/iJuCx02eIhNexq9o24aYJa4
rFSuOYwM4Qf+AE+ufa6RmMWZd94Ppud3mpoJ/Gpy0wWe3MivmtWWRIBzgQzGZpqG
tpcnJLwBWtxQGL6ZUFyrjNy1QxGRMPFM/dk8fqFW2mwWlmbRzuRxiRpDZf6DYg3d
Lr508W+kSJEDmzk4PCFwyocMNSOSTMbRuOwhd9Urf9y4noptD7PD9aLz9Xr70bOh
pTIymTT3aUKIlGKPdgk5zyFPJJuM+MBgHLnt6o6kyDC5BDWtUFkuitVPxAj5yiMG
W5sQJheXoDKLXuHwDFFBV3XB2p+JPm1NcH96RVbh9EAsHrAwyJba9kWtNFO5+X4=
=v9s+
-----END PGP SIGNATURE-----